-
Notifications
You must be signed in to change notification settings - Fork 848
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Loose package weight #546
Loose package weight #546
Conversation
@ankurk91 Thanks! Do you know if it'd be possible to make this a whitelist instead of a blacklist like you can do with I generally find this strategy to be more effective because you can just whitelist the most important stuff like |
While https://git-scm.com/docs/git-archive#ATTRIBUTES Most of the packages already following same pattern see |
@ankurk91 Ah, yes I understand the difference between
You basically start with a coarse rule that says "ignore all", then you pull individual files or directories back in for consideration. |
I got your point. Unfortunately I couldn't find option to whitelist files in We can test it locally by creating the Now check the contents of the zip file |
@brandur-stripe git throws an error saying
|
.gitattributes
Outdated
/.vscode export-ignore | ||
/tests export-ignore | ||
/examples export-ignore | ||
.coveralls.yml export-ignore |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple minor asks:
- Since you're using the prefixing
/
for the first set of these, would you mind just using it for all of them? - Can you alphabetize the list?
- Can you add a short comment to the top of the file indicating that the purpose of this list is to make sure that these files are excluded from the final Composer package.
- Can you squash down your commits?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@brandur-stripe
Done
Cool. Thanks for taking a look at that anyway! Added a few asks above, but otherwise this looks fine. Thanks! |
Looks good. Thanks! |
Hi,
Let's not publish all those file.
.gitattributes
can be used to exclude files from final archive that is downloaded by composer.Read more